search

rnpgp / ruby-rnp

Ruby bindings for librnp
https://www.rnpgp.org
MIT License
7 stars 3 forks source link

Use Input.from_path instead of Input.from_io #67

Closed ni4 closed 4 years ago

ni4 commented 4 years ago

Not sure whether it is correct way to fix the issues (or we should fix Input.from_io instead?). Got some semi-random failures in rnp PR tests run, and it doesn't seem to be related to library code updates.

Changed in this way works locally 100% cases, could it be related to some ruby updates or whatever else?

ni4 commented 4 years ago

Update: it fails on clean pull request (see https://github.com/rnpgp/rnp/pull/1096 ), seems something really changed on ruby side.

dewyatt commented 4 years ago

Update: it fails on clean pull request (see rnpgp/rnp#1096 ), seems something really changed on ruby side.

Sorry for the slow response. I do know what's causing the failures, it's something that's been in the back of my mind for a while, I'll have to think about how to fix it.

dewyatt commented 4 years ago

So I think we no longer need this, things should be stable now, but let me know if you're still seeing random failures.

ni4 commented 4 years ago

Yeah, it looks like things are good now. Except Windows build, but it doesn't use ruby anyway. Thanks for your efforts, @dewyatt!

dewyatt commented 4 years ago

Yeah I don't know what's up with the Windows build. I did see some people reporting issues in the GHA community, so I'm mostly hoping that one resolves itself.