rnpgp / ruby-rnp

Ruby bindings for librnp

https://www.rnpgp.org

MIT License

7 stars 3 forks source link

Update timeout for the signature checks in sign_spec.rb #79

Closed ni4 closed 2 years ago

ni4 commented 2 years ago

Latest changes in RNP (see https://github.com/rnpgp/rnp/pull/1737) introduce key secret material checks before the first operation. This increases time needed to do sign/verify steps, failing corresponding ruby-rnp test.

ni4 commented 2 years ago

@CAMOBAP As I understand you may have an idea why metanorma/metanorma-build-scripts/native-deps-action started to fail here? Action didn't change since last commits here. cc @ronaldtse

CAMOBAP commented 2 years ago

@ni4 as far as I see it try to ldd lib/rnp/ffi/librnp.rb instead ldd lib/rnp/ffi/librnp.so...

I have added more debug logs, let me restart to get more details

ni4 commented 2 years ago

@CAMOBAP thanks!

ni4 commented 2 years ago

@CAMOBAP Hm, wondering where it is supposed to download librnp.so from or how it should compile it, maybe I should not change version to v0.15.2.

ni4 commented 2 years ago

@CAMOBAP Please ignore the previous comment, mislooked build process in the bundle exec step.

CAMOBAP commented 2 years ago

@CAMOBAP Hm, wondering where it is supposed to download librnp.so from or how it should compile it, maybe I should not change version to v0.15.2.

you can compile it with bundle exec rake gem:native for current platform

It really strange that python cannot find lib/rnp/ffi/librnp.so with pattern lib/rnp/ffi/*librnp*.so...

@ni4 could you please report a ticket to metanorma/metanorma-build-scripts

ni4 commented 2 years ago

@CAMOBAP Sure, will create a ticket. Strange since link to librnp.so file is in place:

mkdir -p pkg/rnp-1.0.4-x86_64-linux/lib/rnp/ffi
rm -f pkg/rnp-1.0.4-x86_64-linux/lib/rnp/ffi/librnp.rb
ln lib/rnp/ffi/librnp.rb pkg/rnp-1.0.4-x86_64-linux/lib/rnp/ffi/librnp.rb
rm -f pkg/rnp-1.0.4-x86_64-linux/lib/rnp/ffi/librnp.so
ln lib/rnp/ffi/librnp.so pkg/rnp-1.0.4-x86_64-linux/lib/rnp/ffi/librnp.so

codecov[bot] commented 2 years ago

Codecov Report

Merging #79 (e189e21) into main (31e051b) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #79   +/-   ##
=======================================
  Coverage   98.49%   98.49%           
=======================================
  Files          42       42           
  Lines        3326     3326           
=======================================
  Hits         3276     3276           
  Misses         50       50

Impacted Files	Coverage Δ
spec/sign/sign_spec.rb	`94.64% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 31e051b...e189e21. Read the comment docs.

ronaldtse commented 2 years ago

Thank you @ni4!

(@CAMOBAP let's keep RNP outside of Metanorma build scripts.)