codecov[bot]
commented
2 years ago Codecov Report
Merging #81 (d06499c) into main (a477b42) will decrease coverage by
0.03%. The diff coverage is50.00%.:exclamation: Current head d06499c differs from pull request most recent head e04d8da. Consider uploading reports for the commit e04d8da to get more accurate results
@@ Coverage Diff @@
## main #81 +/- ##
==========================================
- Coverage 98.49% 98.46% -0.04%
==========================================
Files 42 42
Lines 3328 3328
==========================================
- Hits 3278 3277 -1
- Misses 50 51 +1 | Impacted Files | Coverage Δ | |
|---|---|---|
| lib/rnp/misc.rb | 98.93% <ø> (-1.07%) |
:arrow_down: |
| spec/generate/generate_spec.rb | 99.40% <50.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update a477b42...e04d8da. Read the comment docs.
maxirmx
The way the test suite distinguishes between RNP 0.16.x releases and master branch (and future releases) is unfortunate as it looks at the last commit date. So fresh commits which are intended to become 0.16.1 make it treated the same as master, although the new feature (present only on master so far) is not being backported.
This change should be landed in coordination with another change for the RNP repo, changing version.txt from
0.16.0to0.17.0or something which would cause the distinction to work as intended.