rnpgp / ruby-rnp

Ruby bindings for librnp
https://www.rnpgp.org
MIT License
7 stars 3 forks source link

Update tests to correctly work with new signature verification behaviour. #83

Closed ni4 closed 2 years ago

ni4 commented 2 years ago

Tests relied on the requirement of all signature being valid during verification. However, via issue https://github.com/rnpgp/rnp/issues/1820 and PR this behaviour is going to be changed via PR https://github.com/rnpgp/rnp/pull/1896

ni4 commented 2 years ago

@ronaldtse Should we do something with errors reported by hound? Not sure where to configure it and what move expect do mean, as for me changes use the same semantics as all the surrounding code.

codecov[bot] commented 2 years ago

Codecov Report

Merging #83 (aa9c86d) into main (a477b42) will decrease coverage by 96.08%. The diff coverage is 0.00%.

:exclamation: Current head aa9c86d differs from pull request most recent head acf23da. Consider uploading reports for the commit acf23da to get more accurate results

@@            Coverage Diff             @@
##             main     #83       +/-   ##
==========================================
- Coverage   98.49%   2.41%   -96.09%     
==========================================
  Files          42      30       -12     
  Lines        3328    2322     -1006     
==========================================
- Hits         3278      56     -3222     
- Misses         50    2266     +2216     
Impacted Files Coverage Δ
spec/sign/simple_sign_spec.rb 0.63% <0.00%> (-99.37%) :arrow_down:
spec/misc_spec.rb 0.84% <0.00%> (-99.16%) :arrow_down:
spec/rnp_spec.rb 0.90% <0.00%> (-99.10%) :arrow_down:
spec/rnp_parse_spec.rb 0.96% <0.00%> (-99.04%) :arrow_down:
spec/key/properties/1095C3ED6D43C03B_spec.rb 1.16% <0.00%> (-98.84%) :arrow_down:
spec/generate/generate_spec.rb 0.59% <0.00%> (-98.82%) :arrow_down:
spec/key/properties/2FCADF05FFA501BB_spec.rb 1.28% <0.00%> (-98.72%) :arrow_down:
spec/key/export_spec.rb 1.65% <0.00%> (-98.35%) :arrow_down:
spec/key/properties/7BC6709B15C23A4A_spec.rb 1.76% <0.00%> (-98.24%) :arrow_down:
... and 33 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

ronaldtse commented 2 years ago

@ni4 let's ignore Hound issues for now, we will need to do a Ruby cleanup sometime anyway 😉

ni4 commented 2 years ago

@ronaldtse Okay! Then, let's wait for PR approval... :-)

ni4 commented 2 years ago

@ronaldtse Thanks! Let's merge this then. Agree, we'll need to update this to reflect latest RNP changes as well. Probably after the v0.16.1 release.