Android param patch incorrectly references R.strings

rnpm / rnpm-plugin-link

Allows linking dependencies to your React Native project

MIT License

31 stars 19 forks source link

Android param patch incorrectly references R.strings #86

Closed lostintangent closed 8 years ago

lostintangent commented 8 years ago

We had someone log a bug with CodePush that seems to be due to the fact that RNPM refers to "R.strings" instead of "R.string" when generating the code for a configured param that is referenced in a plugin's packageInstance setting.

I haven't had a chance to look into it yet, but it seems like R.string is in fact the correct member name.

grabbou commented 8 years ago

True, mind sending a pull request? cc: @Kureev

Kureev commented 8 years ago

Oops. I'm wondering why nobody reported this before 😮

lostintangent commented 8 years ago

Yep I can send a PR later this evening when I get home. Thanks guys!

Kureev commented 8 years ago

I've made a PR to fix this issue. Please, take a look