Don't allow basic authentication (web, API) if users list is empty

rnwood / smtp4dev

smtp4dev - the fake smtp email server for development and testing

BSD 3-Clause "New" or "Revised" License

2.97k stars 334 forks source link

Don't allow basic authentication (web, API) if users list is empty #1426

Closed ahmed2m closed 3 months ago

ahmed2m commented 3 months ago

I was locked out today when I was going through the new settings in the web interface by toggling "Require Authentication (web, API)" on while I had no users in the settings/env, couldn't do anything, probably this settings needs to be a little more fool-proof to avoid situations like this.

version: 3.3.6

rnwood commented 3 months ago

This has been done as part of PR #1428. Note that it's only valided in the settings UI and also only applies to the "web" auth setting.