BlurModal hide does not cancel the blurModal view, appears on rotate

rnystrom / RNBlurModalView

Add depth to your alerts.

MIT License

830 stars 143 forks source link

BlurModal hide does not cancel the blurModal view, appears on rotate #13

Closed sundialsoft closed 11 years ago

sundialsoft commented 11 years ago

When the view is hidden then the app rotated the whole screen gets covered in a blurred view with no alert on it. Everything behind the blur is working. I'm needing to nil the BlurModal view after I hide it to stop this happening.

ansani commented 11 years ago

This seems to appears ONLY when you call directly the "hide" method, not when you press the close button. I'm investigating on this issue because I've same behavior on my app ;)

[UPDATE: totally wrong. Issue is present EVEN when you press the close button].

[UPDATE x2: BUG FOUND!!!!!] It appears ONLY when RNBlurModalView is global! If you declare RNBlurModalView locally, issue disappears :)

ansani commented 11 years ago

Just made a Pull Request to fix this issue

rnystrom commented 11 years ago

Awesome, thank you!