search

rnystrom / RNGridMenu

A grid menu with elastic layout, depth of field, and realistic animation.
MIT License
1.28k stars 192 forks source link

Hold-and-move gesture, ViewController-Containment, Cleanup, Empty item spots, Non-centered presentation #5

Closed myell0w closed 11 years ago

myell0w commented 11 years ago

Hi!

Thanks again for the great code! I'm opening this pull request mainly for discussion, I changed quite a lot and I'm not sure if you like all of the changes.

Mainly I added the hold-and-move gesture I asked you about on Twitter, proper ViewController containment and non-centered display (for use in conjunction with a long-press).

Let me know what you think!

cheers, Matthias

rnystrom commented 11 years ago

These changes and additions are just great. Really superb work here. I had been toying around the idea of UIVC containment and opted out of it for simplicity's sake. I've had problems with VC containment before, but this is a really simple and clean implementation. Should really help with orientation events.

Also great work removing redundant code and refactoring. Really helps set a solid base to move forward. I'd love to hear (either here or on Twitter) about any other thoughts or enhancements you might have.

Very happy to merge this request!