search

roach-php / core

The complete web scraping toolkit for PHP.
https://roach-php.dev
1.37k stars 70 forks source link

PHP 8.3 Support #175

Closed sweptsquash closed 11 months ago

sweptsquash commented 1 year ago

This PR adds PHP 8.3 support while maintaining support for 8.1 and 8.2, I’ve also taken the liberty of updating the GitHub action workflows to remove the deprecated warning messages: 

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Included the packages nyholm/psr7 and nyholm/psr7-server to resolve RuntimeException for PSR-17 ResponseFactory implementations see slimphp/Slim Issue 3295.

stefandoorn commented 11 months ago

@ksassnowski We are trying to update a project to PHP 8.3. Unfortunately the roach-php/core dependency is preventing that for us right now. PHP 8.3 support would be greatly appreciated, but I also want to be respectful of your time. Is there anything here that we can help you with? Thanks!

ksassnowski commented 11 months ago

@sweptsquash Thanks a lot for the PR. Sorry for not getting around to it earlier. The changes look good to me 👍