Update images target to generate requirements.txt - Githubissues

road-core / service

Apache License 2.0

10 stars 20 forks source link

Update images target to generate requirements.txt #78

Closed r0x0d closed 1 month ago

r0x0d commented 1 month ago

Description

Type of change

[ ] Refactor
[ ] New feature
[ ] Bug fix
[ ] CVE fix
[ ] Optimization
[ ] Documentation Update
[ ] Configuration Update
[ ] Bump-up dependent library
[ ] Bump-up library or tool used for development (does not change the final image)
[ ] CI configuration change
[ ] Konflux configuration change

Related Tickets & Documents

Related Issue #46
Closes #

Checklist before requesting a review

[ ] I have performed a self-review of my code.
[ ] PR has passed all pre-merge test jobs.
[ ] If it is a core feature, I have added thorough tests.

Testing

Please provide detailed steps to perform tests related to this code change.
How were the fix/results from this change verified? Please provide relevant screenshots or results.

mabulgu commented 1 month ago

Thanks for the PR as this one is merged and I closed mine. But I realized I see no affect of this PR on the Konflux builds as mine was aiming those builds. However, I re-realized that you also deleted those from the usptream so yeah this solution is better for you. In my case I dont use make on my Konflux build pipeline so I will go with the solution on my end. Thanks!