search

roadlabs / chromiumembedded

Automatically exported from code.google.com/p/chromiumembedded
0 stars 1 forks source link

Scroll offset values added to OnScrollOffsetChanged #1561

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. Scroll offset values needed in OnScrollOffsetChanged
2.
3.

What is the expected output? What do you see instead?

What version of the product are you using? On what operating system?
CEF3, branch 2295, rev 2040, linux64

Please provide any additional information below.
patch attached.

Original issue reported on code.google.com by amitkan...@gmail.com on 3 Mar 2015 at 9:45

Attachments:

GoogleCodeExporter commented 9 years ago 
Thanks for the patch. Some comments:

1. The current underlying Chromium type (gfx::Vector2dF) uses float values. 
According to a comment [1] in LayerTreeHostImpl::MakeCompositorFrameMetadata() 
this type will be changed to gfx::ScrollOffset at some point in the future and 
that type uses double values. Let's use double values now in the CEF API to 
avoid potential rounding errors in the future.

2. Wrap lines at 80 characters.

3. Create patch files using the `git diff --no-prefix` command (this removes 
the a/ b/ prefixes from the file paths).

[1] 
https://code.google.com/p/chromium/codesearch#chromium/src/cc/trees/layer_tree_h
ost_impl.cc&l=1449

Added in trunk revision 2052 with the above changes.

Original comment by magreenb...@gmail.com on 6 Mar 2015 at 5:50