search

roadrunner-php / issues

Home for the RoadRunner-PHP issues and discussions ❤️
MIT License
2 stars 0 forks source link

[🐛 BUG]: spiral/roadrunner-worker - Sending `null` in response header breaks serialization #33

Closed FluffyDiscord closed 5 months ago

FluffyDiscord commented 5 months ago

No duplicates 🥲.

What happened?

Sending null value in a response header fails due to null not being able to "convert to string"

image

I would expect the package to strip invalid headers or at least throw a helpful exception, instead of this cryptic thing.

Version (package version)

spiral/roadrunner-worker v3.5.0

How to reproduce the issue?

Send back null in a header.

image

Relevant log output

No response

rustatian commented 5 months ago

Hey @FluffyDiscord 👋 Would you be able to send a PR to fix that? 🙏

FluffyDiscord commented 5 months ago

I guess I can try. How should it behave then, throw an exception, or strip the invalid header?

rustatian commented 5 months ago

@msmakouz Could you please help with the behavior here?

msmakouz commented 5 months ago

@FluffyDiscord Hi, it was fixed in v3.5.1. Could you please check?

FluffyDiscord commented 5 months ago

Can confirm its fixed, thank you.