Closed eldario closed 3 years ago
Merging #34 (1b164b9) into master (078c280) will decrease coverage by
8.44%
. The diff coverage is59.13%
.
@@ Coverage Diff @@
## master #34 +/- ##
============================================
- Coverage 96.98% 88.54% -8.45%
- Complexity 118 140 +22
============================================
Files 27 29 +2
Lines 299 384 +85
============================================
+ Hits 290 340 +50
- Misses 9 44 +35
Impacted Files | Coverage Δ | Complexity Δ | |
---|---|---|---|
src/Commands/StartCommand.php | 0.00% <0.00%> (ø) |
4.00 <4.00> (?) |
|
src/RunParams.php | 100.00% <100.00%> (ø) |
13.00 <13.00> (?) |
|
src/Worker.php | 99.03% <100.00%> (+3.58%) |
31.00 <11.00> (+5.00) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 078c280...fd7d492. Read the comment docs.
Maybe use symfony/console for a working with command flags?
Another try with InputInterface
, what do u think, @tarampampam?
Looks better, but not enough for production usage :(
We can talk offline about it, if u want
I move in small steps so as not to do unnecessary work, @tarampampam
Already made in #35, thank you!
Description
Added
Fixes # (issue)
33
Checklist
CHANGELOG.md
file