Closed rustatian closed 2 years ago
Merging #134 (d6e8b55) into master (62c5131) will increase coverage by
0.22%
. The diff coverage is94.33%
.
@@ Coverage Diff @@
## master #134 +/- ##
==========================================
+ Coverage 65.10% 65.33% +0.22%
==========================================
Files 138 138
Lines 10987 11007 +20
==========================================
+ Hits 7153 7191 +38
+ Misses 3109 3094 -15
+ Partials 725 722 -3
Impacted Files | Coverage Δ | |
---|---|---|
http/config/uploads_config.go | 86.95% <84.21%> (-13.05%) |
:arrow_down: |
http/handler/handler.go | 81.05% <100.00%> (+0.40%) |
:arrow_up: |
http/handler/parse.go | 95.87% <100.00%> (-0.05%) |
:arrow_down: |
http/handler/request.go | 78.48% <100.00%> (ø) |
|
http/handler/uploads.go | 80.88% <100.00%> (+7.11%) |
:arrow_up: |
http/plugin.go | 77.30% <100.00%> (+0.32%) |
:arrow_up: |
tcp/plugin.go | 72.17% <0.00%> (+0.86%) |
:arrow_up: |
redis/pubsub/pubsub.go | 72.86% <0.00%> (+2.32%) |
:arrow_up: |
boltdb/boltjobs/listener.go | 64.15% <0.00%> (+2.83%) |
:arrow_up: |
... and 3 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 62c5131...d6e8b55. Read the comment docs.
Reason for This PR
Description of Changes
http.uploads
config ->http.uploads.allow
. With the new options the user will be able to use only allowed file extensions instead of blacklisting all possible files extensions via thehttp.uploads.forbid
option.http.uploads.allow
is empty. That means, that theallow
check will be skipped.http.uploads.allow
andhttp.uploads.forbid
contains both the same extension,http.uploads.forbid
has higher priority, so, the extension will be forbidden.Config:
License Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.
PR Checklist
[Author TODO: Meet these criteria.]
[Reviewer TODO: Verify that these criteria are met. Request changes if not]
git commit -s
).CHANGELOG.md
.