Closed rustatian closed 2 years ago
Merging #152 (1ff2ff5) into master (4000d93) will increase coverage by
0.34%
. The diff coverage is75.87%
.
@@ Coverage Diff @@
## master #152 +/- ##
==========================================
+ Coverage 67.23% 67.58% +0.34%
==========================================
Files 135 135
Lines 10292 10497 +205
==========================================
+ Hits 6920 7094 +174
- Misses 2653 2664 +11
- Partials 719 739 +20
Impacted Files | Coverage Δ | |
---|---|---|
amqp/amqpjobs/redial.go | 66.66% <ø> (ø) |
|
amqp/plugin.go | 100.00% <ø> (ø) |
|
beanstalk/plugin.go | 100.00% <ø> (ø) |
|
boltdb/boltjobs/config.go | 100.00% <ø> (ø) |
|
boltdb/boltjobs/listener.go | 55.35% <0.00%> (-3.14%) |
:arrow_down: |
boltdb/plugin.go | 82.35% <ø> (ø) |
|
http/attributes/attributes.go | 70.00% <ø> (ø) |
|
http/handler/handler.go | 79.68% <ø> (ø) |
|
http/handler/request.go | 78.48% <ø> (ø) |
|
http/handler/uploads.go | 80.88% <ø> (ø) |
|
... and 52 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update c9e1b66...1ff2ff5. Read the comment docs.
Reason for This PR
closes: #32
Description of Changes
.rr.yaml
now support versions. You may safely use your old configurations w/o specifying versions. Configuration w/o version will be treated as2.6
. It is safe to use configuration w/o version or with version2.6
with RR2.7
because RR is able to automatically transform the old configuration. But if you use configuration version2.7
you must update thejobs
pipelines config.At this point we can guarantee, that no breaking changes will be introduced in the configuration w/o auto-convert from the older configuration versions
For example, if we introduce a configuration update let's say in version
2.10
, we will support automatic conversion from at least 2 previous versions w/o involving the user into the process. In the example case, versions2.9
and2.8
will be automatically converted. From our release cycle, you will have at least 2 months to update the configuration from version2.8
and 3 months from2.9
.Version located at the top of the.rr.yaml
:Compatibility matrix located here: TODO
Before:
After:
Now, pipelines have only
driver
key with the configuration under theconfig
key. We did that to uniform configuration across all drivers (like in theKV
).License Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.
PR Checklist
[Author TODO: Meet these criteria.]
[Reviewer TODO: Verify that these criteria are met. Request changes if not]
git commit -s
).CHANGELOG.md
.