roadrunner-server / roadrunner-plugins

📦 Home for the roadrunner plugins
MIT License
25 stars 9 forks source link

refactoring(config): remove unused code, reuse version pointer #159

Closed rustatian closed 2 years ago

rustatian commented 2 years ago

Reason for This PR

Description of Changes

License Acceptance

By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.

PR Checklist

[Author TODO: Meet these criteria.] [Reviewer TODO: Verify that these criteria are met. Request changes if not]

codecov[bot] commented 2 years ago

Codecov Report

Merging #159 (d4c6178) into master (0f684db) will increase coverage by 0.03%. The diff coverage is 31.25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #159      +/-   ##
==========================================
+ Coverage   67.35%   67.38%   +0.03%     
==========================================
  Files         135      134       -1     
  Lines       10497    10477      -20     
==========================================
- Hits         7070     7060      -10     
+ Misses       2685     2677       -8     
+ Partials      742      740       -2     
Impacted Files Coverage Δ
grpc/config.go 36.90% <0.00%> (-0.75%) :arrow_down:
config/plugin.go 62.32% <16.66%> (-0.87%) :arrow_down:
config/versions.go 77.37% <80.00%> (+0.34%) :arrow_up:
beanstalk/beanstalkjobs/item.go 73.97% <0.00%> (-2.74%) :arrow_down:
tcp/plugin.go 71.92% <0.00%> (-0.88%) :arrow_down:
tcp/handler/handler.go 57.43% <0.00%> (+6.08%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0f684db...d4c6178. Read the comment docs.