Closed rustatian closed 2 years ago
This pull request introduces 6 alerts when merging d65059862d4c95f871bdb5ea9c7daf9614c60001 into dd129813f89713a950def9eb3e45c2553821bd7d - view on LGTM.com
new alerts:
Merging #184 (ff8571a) into master (7c22149) will increase coverage by
0.29%
. The diff coverage is68.57%
.
@@ Coverage Diff @@
## master #184 +/- ##
==========================================
+ Coverage 67.36% 67.65% +0.29%
==========================================
Files 134 133 -1
Lines 10488 10414 -74
==========================================
- Hits 7065 7046 -19
+ Misses 2681 2632 -49
+ Partials 742 736 -6
Impacted Files | Coverage Δ | |
---|---|---|
beanstalk/beanstalkjobs/config.go | 68.42% <ø> (ø) |
|
beanstalk/beanstalkjobs/item.go | 76.71% <ø> (+2.73%) |
:arrow_up: |
boltdb/boltjobs/item.go | 45.32% <ø> (ø) |
|
boltdb/boltjobs/listener.go | 55.35% <0.00%> (ø) |
|
grpc/proxy/proxy.go | 60.41% <ø> (-0.55%) |
:arrow_down: |
http/metrics.go | 100.00% <ø> (ø) |
|
http/middleware/headers/plugin.go | 87.83% <ø> (ø) |
|
http/middleware/new_relic/error.go | 100.00% <ø> (ø) |
|
http/middleware/new_relic/plugin.go | 0.00% <ø> (ø) |
|
http/middleware/static/etag.go | 65.90% <ø> (ø) |
|
... and 103 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 7c22149...ff8571a. Read the comment docs.
This pull request introduces 6 alerts when merging f3bda3bda7dd61dc6aca2d6ca195b9408195bca6 into dd129813f89713a950def9eb3e45c2553821bd7d - view on LGTM.com
new alerts:
This pull request introduces 6 alerts when merging 709e94c91da429799c03de4ccd9696fd8bd47834 into dd129813f89713a950def9eb3e45c2553821bd7d - view on LGTM.com
new alerts:
This pull request introduces 6 alerts when merging 72c8c0dbe8005484e65830dc647bf2acd6e80e97 into dd129813f89713a950def9eb3e45c2553821bd7d - view on LGTM.com
new alerts:
This pull request introduces 6 alerts when merging 485a080821fb3340f586fbde4383f87efdebfade into dd129813f89713a950def9eb3e45c2553821bd7d - view on LGTM.com
new alerts:
This pull request introduces 6 alerts when merging ff8571af3bc92ceb2f91994a8b49f8564eb3d9d2 into dd129813f89713a950def9eb3e45c2553821bd7d - view on LGTM.com
new alerts:
Reason for This PR
closes: https://github.com/spiral/roadrunner-plugins/issues/180 ref: https://github.com/spiral/roadrunner/issues/880 ref: https://github.com/spiral/roadrunner/pull/881
Description of Changes
Reset
method instead of theDestroy
and replace.License Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.
PR Checklist
[Author TODO: Meet these criteria.]
[Reviewer TODO: Verify that these criteria are met. Request changes if not]
git commit -s
).CHANGELOG.md
.