rustatian commented 2 years ago

Reason for This PR

ref: #66 , level 1 closes: #187 closes: #185

Description of Changes

Fix bug with incorrect usage of the ResponseWriter in the new_relic plugin: #185

A possible configuration for the cache middleware:

http:
# .....
    middleware: ["cache"]
    cache:
        driver: memory
        cache_methods: ["GET", "HEAD", "POST"] # only GET by default
        config: {}

Supported headers:

Authorization: https://datatracker.ietf.org/doc/html/rfc7234#section-3.2. RR will not save the requests if the Authorization header exists.
Age, max-age
GET requests and 200 OK response codes.

License Acceptance

By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.

PR Checklist

[Author TODO: Meet these criteria.] [Reviewer TODO: Verify that these criteria are met. Request changes if not]

[x] All commits in this PR are signed (git commit -s).
[x] The reason for this PR is clearly provided (issue no. or explanation).
[x] The description of changes is clear and encompassing.
[x] Any required documentation changes (code and docs) are included in this PR.
[x] Any user-facing changes are mentioned in CHANGELOG.md.
[x] All added/changed functionality is tested.

codecov[bot] commented 2 years ago

Codecov Report

Merging #186 (f2b5b3b) into master (7c27f9f) will increase coverage by 0.70%. The diff coverage is 77.21%.

@@            Coverage Diff             @@
##           master     #186      +/-   ##
==========================================
+ Coverage   67.65%   68.36%   +0.70%     
==========================================
  Files         133      141       +8     
  Lines       10414    10756     +342     
==========================================
+ Hits         7046     7353     +307     
- Misses       2632     2633       +1     
- Partials      736      770      +34

Impacted Files	Coverage Δ
amqp/amqpjobs/consumer.go	`69.33% <ø> (ø)`
amqp/amqpjobs/item.go	`73.28% <ø> (ø)`
amqp/amqpjobs/redial.go	`66.66% <ø> (ø)`
beanstalk/beanstalkjobs/consumer.go	`72.54% <ø> (ø)`
beanstalk/beanstalkjobs/item.go	`73.97% <ø> (-5.48%)`	:arrow_down:
boltdb/boltjobs/consumer.go	`66.53% <ø> (ø)`
boltdb/boltjobs/item.go	`45.32% <ø> (ø)`
boltdb/boltkv/driver.go	`51.69% <ø> (ø)`
broadcast/rpc.go	`69.81% <ø> (ø)`
http/handler/request.go	`79.76% <ø> (ø)`
... and 81 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7c27f9f...f2b5b3b. Read the comment docs.