Closed rustatian closed 2 years ago
Merging #53 (38dfde0) into master (208cd4e) will increase coverage by
0.41%
. The diff coverage is94.03%
.
@@ Coverage Diff @@
## master #53 +/- ##
==========================================
+ Coverage 67.13% 67.55% +0.41%
==========================================
Files 110 110
Lines 9175 9233 +58
==========================================
+ Hits 6160 6237 +77
+ Misses 2386 2372 -14
+ Partials 629 624 -5
Impacted Files | Coverage Δ | |
---|---|---|
boltdb/plugin.go | 77.77% <ø> (-4.05%) |
:arrow_down: |
jobs/plugin.go | 57.66% <ø> (+0.11%) |
:arrow_up: |
memory/plugin.go | 80.00% <ø> (-3.34%) |
:arrow_down: |
http/handler/request.go | 77.92% <50.00%> (-2.76%) |
:arrow_down: |
redis/plugin.go | 68.18% <50.00%> (-1.82%) |
:arrow_down: |
memcached/plugin.go | 58.82% <85.71%> (ø) |
|
memcached/memcachedkv/driver.go | 51.87% <92.30%> (ø) |
|
memory/memorypubsub/pubsub.go | 87.71% <92.30%> (+0.44%) |
:arrow_up: |
redis/kv/kv.go | 57.73% <92.30%> (+0.50%) |
:arrow_up: |
redis/pubsub/pubsub.go | 72.86% <94.73%> (+3.51%) |
:arrow_up: |
... and 14 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 208cd4e...38dfde0. Read the comment docs.
Reason for This PR
Description of Changes
Stop
method to the pubsub interface to properly close underlying drivers and free up the associated resources.License Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.
PR Checklist
[Author TODO: Meet these criteria.]
[Reviewer TODO: Verify that these criteria are met. Request changes if not]
git commit -s
).CHANGELOG.md
.