roadrunner-server / roadrunner-plugins

📦 Home for the roadrunner plugins
MIT License
25 stars 9 forks source link

fix(http): superfluous response.WriteHeader call #80

Closed rustatian closed 3 years ago

rustatian commented 3 years ago

Reason for This PR

Description of Changes

License Acceptance

By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.

PR Checklist

[Author TODO: Meet these criteria.] [Reviewer TODO: Verify that these criteria are met. Request changes if not]

codecov[bot] commented 3 years ago

Codecov Report

Merging #80 (b305fa3) into master (cdd2080) will decrease coverage by 0.37%. The diff coverage is 72.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #80      +/-   ##
==========================================
- Coverage   68.98%   68.60%   -0.38%     
==========================================
  Files         118      118              
  Lines        9920     9925       +5     
==========================================
- Hits         6843     6809      -34     
- Misses       2403     2443      +40     
+ Partials      674      673       -1     
Impacted Files Coverage Δ
http/handler/handler.go 85.89% <72.00%> (+0.74%) :arrow_up:
jobs/listener.go 35.15% <0.00%> (-12.50%) :arrow_down:
sqs/item.go 65.78% <0.00%> (-7.24%) :arrow_down:
websockets/executor/executor.go 62.87% <0.00%> (-5.31%) :arrow_down:
jobs/metrics.go 95.91% <0.00%> (-4.09%) :arrow_down:
beanstalk/item.go 77.14% <0.00%> (-2.86%) :arrow_down:
jobs/plugin.go 61.35% <0.00%> (-0.49%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update cdd2080...b305fa3. Read the comment docs.