search

roadrunner-server / roadrunner

🤯 High-performance PHP application server, process manager written in Go and powered with plugins
https://docs.roadrunner.dev
MIT License
7.84k stars 407 forks source link

[💡 FEATURE REQUEST]: Replace `zap` logger with the official Go `log/slog` logger #1750

Open rustatian opened 11 months ago

rustatian commented 11 months ago

Plugin

Logger

I have an idea!

The Golang official log/slog package is out from the experimental packages. It is time to update our zap logger from Uber with the official one.

Kaspiman commented 5 months ago

Can i help you with this epic? Looks like there many simple work for PHP dev @rustatian

rustatian commented 5 months ago

I'm still not sure about this ticket. According to the benchmarks, slog is much much slower than zap: link.

rustatian commented 5 months ago

@Kaspiman btw, if you want to contribute, I can suggest you this ticket: https://github.com/roadrunner-server/roadrunner/issues/1742. Here, you may use json-rpc like payloads with method mapping to the RR RPC methods.

Kaspiman commented 5 months ago

@rustatian I'm interested in implementing this feature, because of https://github.com/roadrunner-server/roadrunner/issues/1708#issuecomment-1761611248

rustatian commented 5 months ago

To move to the official packages, it has to be at least not so behind the zap in terms of performance. I don't think, that the slog update happened this year.