apple-ib-tb: Add more T2 USB HID IDs

roadrunner2 / macbook12-spi-driver

Input driver for the SPI touchpad / keyboard found in the 12" MacBook (MacBook8,1 + MacBook9,1) and 2016 through 2018 Macbook Pro's (MacBookPro13,* and 14,*); a Touch Bar driver is also available.

GNU General Public License v2.0

251 stars 49 forks source link

apple-ib-tb: Add more T2 USB HID IDs #29

Closed aunali1 closed 5 years ago

aunali1 commented 5 years ago

Apparently, each variant of the T2 based devices (MacbookPro15,1/2/etc.) have their own unique associated HID ID. Currently we only support MacbookPro15,2 (0x027b).

This commit adds support for the following additional devices:

MacbookAir8,1 (0x027a)
MacbookPro15,1 (0x027c)

Tested working on a MacbookPro15,1 device.

Tested-by: Aun-Ali Zaidi admin@kodeit.net Signed-off-by: Aun-Ali Zaidi admin@kodeit.net

roadrunner2 commented 5 years ago

Thanks for this pull. However, I think I have a more generic solution, one which doesn't involve constantly adding additional id's every time a new machine/model comes out. I just pushed those changes now - could you see if this latest version works for you? If that approach turns out not to work, then I'll be happy to apply your pull, though.

aunali1 commented 5 years ago

@roadrunner2 Yep, works fine. I'll go ahead and close this PR.

roadrunner2 commented 5 years ago

Thanks for testing!

aunali1 commented 5 years ago

@roadrunner2 Turns out my testing methodology was faulty, The DKMS built module was not being updated properly in my initramfs. After performing a clean rebuild and install I began experiencing the same problem as @mikeeq. My original solution works as expected however.

roadrunner2 commented 5 years ago

@aunali1 Just found and fixed the issue (stupid mistake!). Please try it again.