roadrunner2 / macbook12-spi-driver

Input driver for the SPI touchpad / keyboard found in the 12" MacBook (MacBook8,1 + MacBook9,1) and 2016 through 2018 Macbook Pro's (MacBookPro13,* and 14,*); a Touch Bar driver is also available.
GNU General Public License v2.0
255 stars 50 forks source link

evemu-record stops showing any input when a palm is released slowly from the touchpad #4

Closed peterychuang closed 5 years ago

peterychuang commented 7 years ago

This problem was first discovered when I was trying to make libinput capable of rejecting palm touches based on touch-sizes (see this branch and this thread ).

When I release my palm very slowly from the touchpad, often times the machine fails to respond to the next finger input. evemu-record reveals that when a palm is released slowly, it sometimes stops registering anything in the middle of the slow release. If ABS_MT_TOUCH_MAJOR is above the touch-size threshold the instance evemu-record is stuck, the cursor will fail to move on the next finger input even though evemu-record will register the said input. The cursor will only start moving again on the next touch.

roadrunner2 commented 7 years ago

Interesting - I can confirm that behaviour exactly (I've been using libinput master too recently). However, I think what evemu-record is showing is correct: for a palm I see events start only when palm size threshold is reached (or more precisely: I see a few events, and then it stops as it recognizes that this is a palm, and doesn't start showing events until the pressure is increased to the point where the palm size threshold is reached), and on releasing they stop as soon as it goes under the threshold again. So I think the pointer-is-stuck is a bug in libinput.

roadrunner2 commented 5 years ago

@peterychuang Do you still see this? I can't reproduce this anymore with libinput 1.12.4.

peterychuang commented 5 years ago

@roadrunner2 unfortunately I've recently sold my macbook, so I can't test it any more... sorry.

roadrunner2 commented 5 years ago

Ok, thanks. Closing this then since the bug appears to be fixed.