roadrunner2 / macbook12-spi-driver

Input driver for the SPI touchpad / keyboard found in the 12" MacBook (MacBook8,1 + MacBook9,1) and 2016 through 2018 Macbook Pro's (MacBookPro13,* and 14,*); a Touch Bar driver is also available.
GNU General Public License v2.0
251 stars 49 forks source link

Fix for Kernel Version >= 5.9 #55

Open rado0x54 opened 3 years ago

rado0x54 commented 3 years ago

Fix for #54

Commit of the breaking change of the Kernel: https://github.com/torvalds/linux/commit/78289b4a58b58e9a8a76ef43ffbaf04a097e33c6

JayFoxRox commented 3 years ago

Works for me on mbp14,3 running 5.9.14-arch1-1 :+1:

Without this patch I'd get the problem described in #54.

Code change looks fine, too.

fannullone commented 3 years ago

I have macbbook pro 13,3 and running fc33 I have applied the fix to the apple-ib-als.c:

/ iio_dev = iio_device_alloc(sizeof(als_dev)); / iio_dev = iio_device_alloc(&als_dev->hid_dev->dev, sizeof(als_dev));

Then sudo dkms install applespi/0.1 -k 5.9.16-200.fc33.x86_64/x86_64

which worked fine, then rebooted but still touchbar is not working.

The module doesn't seem to be running: [root@mbp ~]# modprobe apple-ib-tb [root@mbp ~]# lsmod | grep apple-ib-tb [root@mbp ~]#

Any idea what I am missing? Will this fix be available in any upstream kernel for fedora?

divad42 commented 3 years ago

Do you have usbmuxd installed? usbmuxd breaks the touchbar driver.

ghost commented 3 years ago

I just forked this. There hasn't been an update here for 11 months and your patch does work.