roadster-rs / roadster

"Batteries Included" web framework for Rust designed to get you moving fast 🏎️
Apache License 2.0
5 stars 0 forks source link

feat: Add `From` impl to convert db config to ConnectOptions #240

Closed spencewenski closed 3 months ago

spencewenski commented 3 months ago

Add From<Database> impl for ConnectOptions to encapsulate the conversion, which would make it easier if a consumer wants to override the default App#db_connection_options method but keep some of our defaults.

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 64.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 43.68%. Comparing base (ef6e630) to head (00b61b2).

Files Coverage Δ
src/config/database/mod.rs 89.28% <84.21%> (-10.72%) :arrow_down:
src/app/mod.rs 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ef6e630...00b61b2. Read the comment docs.