search

roamingthings / spyglass

A simple mjpeg server for Picamera2
GNU General Public License v3.0
57 stars 12 forks source link

feat: Add compatibility with moonraker update manager #54

Closed AyrtonRicardo closed 12 months ago

AyrtonRicardo commented 12 months ago

This adds the system files as symlink to be able to update via git without invoking any script to get Service up-to-date.

This adds necessary changes on moonraker update manager to "git pull" the repo automatically. Using "beta" because it gets tagged commits, instead of pure main branch.

mryel00 commented 12 months ago

Hey, thank you for your PR 😄 @KwadFan could you have a look at this? I think you are the most experienced one in terms of moonraker integration

mryel00 commented 12 months ago

@AyrtonRicardo Can you edit your PR name to match the conventional commit guidelines?

AyrtonRicardo commented 12 months ago

@mryel00 thank you for your inputs. Now the fix were made, and I've included a informative while running make upgrade-moonraker command.

mryel00 commented 12 months ago

@AyrtonRicardo you don't have to force push. We will sqaush and merge at the end. The PR name is the only/most important thing as this will be the commit name.

mryel00 commented 12 months ago

I will merge this as soon as @KwadFan got a look at it, that we didn't forget something important in the context of Moonraker updating. But overall it looks good to me now 😄 Thank you again for this PR ❤️

AyrtonRicardo commented 12 months ago

@mryel00 thanks for checking out and re-check the text. I noticed a error in my script while running sed, for some reason it was leaving the file moonraker.asvc empty. Fixed it using a different approach with sed and stored a backup before modifying it, just in case a user finds something unexpected like I did, to rewrite the whole file can be a pain, 😢