Bypass selectable=false with keyboard

rob-balfre / svelte-select

Svelte Select. A select component for Svelte

https://svelte-select-examples.vercel.app

Other

1.26k stars 175 forks source link

Bypass selectable=false with keyboard #447

Closed BAllendorf-OneFiber closed 1 year ago

BAllendorf-OneFiber commented 1 year ago

While I can't selected an item with selectable: false by mouse/clicking, I can do select it by typing the label and pressing the enter key.

This works for the Complex advanced example. When using Groups, one hast to press the up/down arrow key and afterwards one can select the item with enter (5.0.0-beta.16).

I'm not sure if this is a feature or a bug, but I expected it to not work like this.

rob-balfre commented 1 year ago

Partially fixed in beta.17 but you can still hit tab to select. Will fix up. Thanks

rob-balfre commented 1 year ago

Fixed in 5.0.0-beta.23.

BAllendorf-OneFiber commented 1 year ago

Thank you for looking into this!

I just tried it out here and think there are still a few edge cases:

in the complex example, I can't jump out via ENTER but, for example, by using TAB (and the input still says "Cake" even though, for complete nonsense, the input gets reset)
in multi, I can enter "Cake" and hit ENTER, it gets added as any other value would
group is very special: after I typed two characters belonging to "Cake" (e.g., "Ca" or "ak"), Javascript runs into a RangeError "Maximum call stack size exceeded"

rob-balfre commented 1 year ago

@BAllendorf-OneFiber 5.0.0-beta.28 should squash those edge cases. Thanks for finding them.

BAllendorf-OneFiber commented 1 year ago

Awesome, many thanks for the quick response! 👍