search

rob-balfre / svelte-select

Svelte Select. A select component for Svelte
https://svelte-select-examples.vercel.app
Other
1.25k stars 175 forks source link

[Fix] list-item default marker styling #517

Closed sawyerclick closed 1 year ago

sawyerclick commented 1 year ago

Safari auomatically puts a marker on elements styled with display: list-item. Other browsers do not do this. This CSS explicitly removes that styling.

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
svelte-select ✅ Ready (Inspect) Visit Preview Jan 11, 2023 at 0:14AM (UTC)
rob-balfre commented 1 year ago

@sawyerclick there isn't any CSS in Svelte Select that sets display: list-item though, are you setting it yourself somewhere?

sawyerclick commented 1 year ago

It seems that Tailwind's list-item class is the culprit here. It sets items as display: list-item which comes OOTB with a ::marker

rob-balfre commented 1 year ago

haha omg I searched list-item in tailwind docs before my prev comment, haha good to know their search is useless!

sawyerclick commented 1 year ago

I also was extremely confused when list-item didn't show up in search but every other display seemingly does! I found this bug in practice and was able to track it down to list-item

rob-balfre commented 1 year ago

@sawyerclick release in 5.1.1 thanks!