rob-balfre / svelte-select

Svelte Select. A select component for Svelte
https://svelte-select-examples.vercel.app
Other
1.25k stars 175 forks source link

Error: Cannot find module 'svelte-select' #559

Closed nielk closed 1 year ago

nielk commented 1 year ago

Hello, since I updated from 5.2.1 to 5.3.0 I get the following error:

Capture d’écran 2023-02-21 à 08 55 22

If I downgrade to 5.2.1 it works. Do you know how I can fix that ?

Thanks

rob-balfre commented 1 year ago

What setup do you have? SvelteKit?

On Tue, 21 Feb 2023, 6:58 pm Alexandre Oger, @.***> wrote:

Hello, since I updated from 5.2.1 to 5.3.0 I get the following error:

[image: Capture d’écran 2023-02-21 à 08 55 22] https://user-images.githubusercontent.com/4980521/220283028-7ded4742-cb5e-4536-80c8-54c9672ec028.png

If I downgrade to 5.2.1 it works. Do you know how I can fix that ?

Thanks

— Reply to this email directly, view it on GitHub https://github.com/rob-balfre/svelte-select/issues/559, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAUAM7TZSSIBFDA4FJXRTT3WYRYR3ANCNFSM6AAAAAAVCWMH64 . You are receiving this because you are subscribed to this thread.Message ID: @.***>

nielk commented 1 year ago

typescript + svelte + rollup

here is my tsconfig:

{
  "compilerOptions": {
    "target": "es6",
    "lib": ["dom", "dom.iterable", "esnext"],
    "types": ["svelte", "mocha"],
    "strict": true,
    "noImplicitAny": true,
    "skipLibCheck": true,
    "forceConsistentCasingInFileNames": true,
    "noEmit": true,
    "removeComments": true,
    "esModuleInterop": true,
    "module": "esnext",
    "moduleResolution": "node",
    "resolveJsonModule": true,
    "pretty": true,
    "allowJs": false,
    "noUnusedLocals": true,
    "noUnusedParameters": true,
    "noImplicitReturns": true,
    "noFallthroughCasesInSwitch": true,
    "importsNotUsedAsValues": "error",
    "noUncheckedIndexedAccess": true,
    "baseUrl": ".",
    "paths": {
      "_/*": ["./src/*"]
    }
  },
  "include": [
    "src/**/*",
    "test/**/*",
    "build/**/*"
  ],
  "exclude": ["node_modules"]
}
rob-balfre commented 1 year ago

Anything in your roll-up to alias the old svelte-select?

On Tue, 21 Feb 2023, 7:12 pm Alexandre Oger, @.***> wrote:

typescript + svelte + rollup

here is my tsconfig:

{ "compilerOptions": { "target": "es6", "lib": ["dom", "dom.iterable", "esnext"], "types": ["svelte", "mocha"], "strict": true, "noImplicitAny": true, "skipLibCheck": true, "forceConsistentCasingInFileNames": true, "noEmit": true, "removeComments": true, "esModuleInterop": true, "module": "esnext", "moduleResolution": "node", "resolveJsonModule": true, "pretty": true, "allowJs": false, "noUnusedLocals": true, "noUnusedParameters": true, "noImplicitReturns": true, "noFallthroughCasesInSwitch": true, "importsNotUsedAsValues": "error", "noUncheckedIndexedAccess": true, "baseUrl": ".", "paths": { "_/": ["./src/"] } }, "include": [ "src//*", "test/*/", "build//*" ], "exclude": ["node_modules"] }

— Reply to this email directly, view it on GitHub https://github.com/rob-balfre/svelte-select/issues/559#issuecomment-1438018806, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAUAM7Q4XN42ZMNOXG4KNKDWYR2GDANCNFSM6AAAAAAVCWMH64 . You are receiving this because you commented.Message ID: @.***>

rob-balfre commented 1 year ago

I'm gonna revert the build change. Sorry about that. It's a breaking change that needs a major version bump.

Thanks for reporting.

On Tue, 21 Feb 2023, 7:25 pm Rob B, @.***> wrote:

Anything in your roll-up to alias the old svelte-select?

On Tue, 21 Feb 2023, 7:12 pm Alexandre Oger, @.***> wrote:

typescript + svelte + rollup

here is my tsconfig:

{ "compilerOptions": { "target": "es6", "lib": ["dom", "dom.iterable", "esnext"], "types": ["svelte", "mocha"], "strict": true, "noImplicitAny": true, "skipLibCheck": true, "forceConsistentCasingInFileNames": true, "noEmit": true, "removeComments": true, "esModuleInterop": true, "module": "esnext", "moduleResolution": "node", "resolveJsonModule": true, "pretty": true, "allowJs": false, "noUnusedLocals": true, "noUnusedParameters": true, "noImplicitReturns": true, "noFallthroughCasesInSwitch": true, "importsNotUsedAsValues": "error", "noUncheckedIndexedAccess": true, "baseUrl": ".", "paths": { "_/": ["./src/"] } }, "include": [ "src//*", "test/*/", "build//*" ], "exclude": ["node_modules"] }

— Reply to this email directly, view it on GitHub https://github.com/rob-balfre/svelte-select/issues/559#issuecomment-1438018806, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAUAM7Q4XN42ZMNOXG4KNKDWYR2GDANCNFSM6AAAAAAVCWMH64 . You are receiving this because you commented.Message ID: @.***>

nielk commented 1 year ago

No worries, thanks for your responsiveness :)

I would appreciate it if you could have a changelog and/or migration guide for any breaking change version

rob-balfre commented 1 year ago

@nielk yeah was an accidental break - my bad. Fixed in 5.3.1

nielk commented 1 year ago

@rob-balfre Thanks, I updated to 5.3.1 and everything goes well :)