fix: #610 resolve ARIA warnings by defining a role on interactive divs

rob-balfre / svelte-select

Svelte Select. A select component for Svelte

https://svelte-select-examples.vercel.app

Other

1.25k stars 175 forks source link

fix: #610 resolve ARIA warnings by defining a role on interactive divs #624

Closed josdejong closed 10 months ago

josdejong commented 10 months ago

This PR fixes #610.

It adds a role="none" to the three interactive divs, resolving the warnings given by Svelte 4 (tested it by importing svelte-select in a project with Svelte 4).

I've had a look through the list with available ARIA roles but I didn't find meaning rules matching the three cases in this PR, therefore I choose role="none".

vercel[bot] commented 10 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
svelte-select	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 23, 2023 6:52am

rob-balfre commented 10 months ago

@josdejong thanks