search

rob-blackbourn / JetBlack.Network

An experiment in using Rx (reactive extensions) with network sockets for TCP in C#.
MIT License
17 stars 9 forks source link

Observables does not complete #1

Open goekboet opened 7 years ago

goekboet commented 7 years ago

Thanks for an awesome repo. I played around with it trying to get my head around rx and it was really helpful and fun. I think the some of the observables does not handle cancellation properly. observer.OnNext(await listener.AcceptTcpClientAsync()); will not cancel. You have to do something like this.

I can make a pull request if you are willing to consider it.

rob-blackbourn commented 7 years ago

Hi @goekboet

That looks good. I'm happy to incorporate the pull request.

This repository is all about experimenting, and the more accurate they are the better.

Rob

goekboet commented 7 years ago

see #2 A little caveat: I wasn't able to run the project on my computer. I think the .csproj-files are not like expected or something. Dotnet core on OS X. However I tested the same code in another project i have and verified that it worked.