search

rob-luke / Neuroimaging.jl

Neuroimaging in Julia
https://rob-luke.github.io/Neuroimaging.jl
BSD 3-Clause "New" or "Revised" License
48 stars 11 forks source link

Return unitful data for samplingrate #171

Closed rob-luke closed 3 years ago

rob-luke commented 3 years ago

Reference issue

All data should be passed around with units unless explicitly requested by the user.

What does this implement/fix?

samplingrate now returns data with units by default

Additional information

Breaking change

codecov[bot] commented 3 years ago

Codecov Report

Merging #171 (78d2c89) into main (0bed495) will increase coverage by 0.03%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #171      +/-   ##
==========================================
+ Coverage   96.19%   96.23%   +0.03%     
==========================================
  Files          43       42       -1     
  Lines        1394     1406      +12     
==========================================
+ Hits         1341     1353      +12     
  Misses         53       53
Impacted Files Coverage Δ
src/types/EEG/plotting.jl 90.90% <ø> (ø)
src/types/Sensors/Sensors.jl 100.00% <ø> (ø)
src/types/EEG/EEG.jl 94.96% <100.00%> (+0.51%) :arrow_up:
src/types/SSR/Preprocessing.jl 93.93% <100.00%> (ø)
src/types/SSR/Reshaping.jl 97.61% <100.00%> (ø)
src/types/SSR/SSR.jl 100.00% <100.00%> (ø)
src/types/SSR/Statistics.jl 100.00% <100.00%> (ø)
src/Neuroimaging.jl

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0bed495...78d2c89. Read the comment docs.