search

rob-murray / ferver

A Ruby gem to serve files over HTTP, packaged as a Ruby gem
MIT License
14 stars 3 forks source link

Sort the file list alphabetically #23

Closed dkam closed 3 years ago

dkam commented 9 years ago

Title says it all really.

dkam commented 9 years ago

So, I tried my first rebase. But I'm not sure I've done it correctly - I tried pushing a rebased branch back up into github. This looks ok, but I'm not sure it's right.

rob-murray commented 9 years ago

Cool, thanks for all the PRs... I'm working through them when I have the time :)

dkam commented 9 years ago

No worries. I’m enjoying the process. The basic auth changes are a bit more substantial as we need to setup all the options to get the username / password stuff before Sinatra is loaded. Basic Auth should probably be followed closely by SSL.

On 7 Sep 2015, at 17:54 , Robert Murray notifications@github.com wrote:

Cool, thanks for all the PRs... I'm working through them when I have the time :)

— Reply to this email directly or view it on GitHub.

Dan Milne d@nmilne.com http://da.nmilne.com/
http://booko.com.au/

rob-murray commented 9 years ago

Great :)

Are these all use cases you require? Just curious how you are using it... this originated because my team just needed a basic json list of files and download function for a mobile app prototype.

On 7 September 2015 at 10:56, Dan Milne notifications@github.com wrote:

No worries. I’m enjoying the process. The basic auth changes are a bit more substantial as we need to setup all the options to get the username / password stuff before Sinatra is loaded. Basic Auth should probably be followed closely by SSL.

On 7 Sep 2015, at 17:54 , Robert Murray notifications@github.com wrote:

Cool, thanks for all the PRs... I'm working through them when I have the time :)

— Reply to this email directly or view it on GitHub.

Dan Milne d@nmilne.com http://da.nmilne.com/ http://booko.com.au/

— Reply to this email directly or view it on GitHub https://github.com/rob-murray/ferver/pull/23#issuecomment-138256174.

rob-murray commented 9 years ago

I'm gonna hold of on this one because it breaks the file download: the file is requested by the index in the array (a bit hacky I know) and so unless its sorted everywhere then these are out of sync.

If its sorted in the first place in FileList then all is good.