search

rob-murray / jekyll-twitter-plugin

A Liquid tag plugin for the Jekyll blogging engine that embeds Tweets, Timelines and more from Twitter API
MIT License
238 stars 30 forks source link

Set Twitter details from _config.yml #3

Closed ryanburnette closed 9 years ago

ryanburnette commented 9 years ago

It would be nice if the Twitter details could be set in _config.yml. I can do a pull request on this sometime if that's optimal.

rob-murray commented 9 years ago

Yes, this is something I would love to have but not quite got around to implementing.

I had not decided how/where to place the Twitter API credentials, the Jekyll _config.yml is one option, I was wondering if others used this file for credentials or just Jekyll config? Other config files would keep it separate but may be a pain to manage extra files. Whatever it is should probably accept tokens from ENV too so that people dont have to commit secrets.

ryanburnette commented 9 years ago

I'll propose a backwards compatible update. Now just to find the time.

On Dec 2, 2014, at 8:57 AM, Robert Murray notifications@github.com wrote:

Yes, this is something I would love to have but not quite got around to implementing.

I had not decided how/where to place the Twitter API credentials, the Jekyll _config.yml is one option, I was wondering if others used this file for credentials or just Jekyll config? Other config files would keep it separate but may be a pain to manage extra files. Whatever it is should probably accept tokens from ENV too so that people dont have to commit secrets.

— Reply to this email directly or view it on GitHub.

jalcine commented 9 years ago

People can load in more configuration options by using the _data folder.

Another idea, there also could be a .jekyll-twitter-plugin.env file that gets sourced/parsed by this plugin from the root directory.

ryanburnette commented 9 years ago

I made a pull request that adds this functionality. https://github.com/rob-murray/jekyll-twitter-plugin/pull/5