search

rob-murray / jekyll-twitter-plugin

A Liquid tag plugin for the Jekyll blogging engine that embeds Tweets, Timelines and more from Twitter API
MIT License
238 stars 30 forks source link

Extract Twitter secrets from _config.yml or ENV #5

Closed ryanburnette closed 9 years ago

ryanburnette commented 9 years ago

In this version the plugin looks first to _config.yml for the Twitter secrets. If not present there, it'll look to ENV as it did before. This update should not break any implementations of v1.1.1, but will allow users to keep their Twitter secrets in the _config.yml.

I updated the README doc to describe the new procedures.

I didn't update the Gemspec or any version info.

ryanburnette commented 9 years ago

I'll also leave it up to you to fix the @houndci suggestions. ;)

rob-murray commented 9 years ago

Looks good to me - will test and merge this later. I want to fix another issue and then push a new gem version.

Damn, those @houndci warnings are annoying :scream_cat: May have to be turned off...