search

rob-murray / jekyll-twitter-plugin

A Liquid tag plugin for the Jekyll blogging engine that embeds Tweets, Timelines and more from Twitter API
MIT License
238 stars 30 forks source link

Can't get plugin to work #7

Closed ryanburnette closed 9 years ago

ryanburnette commented 9 years ago

I've been troubleshooting for about an hour now and I can't get the plugin to work at all. I've double-checked that my credentials are correct and that the links I'm trying to oembed are correct.

I'll update this issue if I can find anything but I wanted to see if I was the only one dead in the water on v1.2.0.

ryanburnette commented 9 years ago

Same issue on v1.1.1. So it must be something on my end.

ryanburnette commented 9 years ago

Doh. Misspelled oembed. One of those days.

rob-murray commented 9 years ago

Lol. We've all done something similar! Maybe there should be some logging; "Rendering tweet blah... from cache/api", if you dont see it then something has not worked.

ryanburnette commented 9 years ago

I don't think that's necessary. Sleep, however, is necessary.

This isn't related to the issue, but I was curious. I'm writing another Jekyll plugin that makes many API calls that I want to use the Cacheable class you have in use on this plugin. I was reading it over and it looks like it caches forever, or until you manually the .tweet-cache directory. Is that correct?

rob-murray commented 9 years ago

Yes, that what this does at the moment - I copied most of it from the previous plugin but my thinking was that Tweets dont change much so that shouldnt be a problem for the oembed usage. When another feature comes along that can be cached but needs 'refreshing', such as a timeline, then I was going to work out how to expire the cache.

ryanburnette commented 9 years ago

Well it's working beautifully for my embed.ly plugin. I forked this but it's changed quite a bit from the original now https://github.com/ryanburnette/jekyll-embedly-plugin

On Thu Jan 08 2015 at 4:50:31 PM Robert Murray notifications@github.com wrote:

Yes, that what this does at the moment - I copied most of it from the previous plugin but my thinking was that Tweets dont change much so that shouldnt be a problem for the oembed usage. When another feature comes along that can be cached but needs 'refreshing', such as a timeline, then I was going to work out how to expire the cache.

— Reply to this email directly or view it on GitHub https://github.com/rob-murray/jekyll-twitter-plugin/issues/7#issuecomment-69255882 .