rob-race / react-trix

React wrapper around Trix editor from Basecamp + some lightweight features
ISC License
213 stars 42 forks source link

Shouldn't check for 204 status code for upload #10

Closed tschoffelen closed 6 years ago

tschoffelen commented 6 years ago

Currently, the file upload part of this (awesome!) library checks for a "204 No Content" status code, and then goes on to read its responseText.

Regardless of whether it is actually possible to send a 204 and also send content (which doesn't seem to be the case on my webserver - but that might be a config thing), I don't think this is correct. Can this perhaps be made configurable, perhaps with a more sensible default like 201?

Cheers!