search

rob3000 / nestjs-kafka

NestJS integration with KafkaJS
The Unlicense
130 stars 44 forks source link

Confused by the first registration of schema #38

Closed Annyxh closed 2 years ago

Annyxh commented 2 years ago

Sorry, my understanding may be wrong. I found we only have getSchemaIds in KafkaAvroRequestSerializer. Does that mean we don't support registering these schema to avro by nestJs app?

rob3000 commented 2 years ago

Hey @Annyxh , That's correct, currently the expectation is that the AVRO schema is defined and already created in Schema Registry. There is a test that programmatically sends an avro schema to SR here: https://github.com/rob3000/nestjs-kafka/blob/master/test/utils.ts#L15 which you could look to do on your service start? Otherwise happy to accept PRs/suggestions for it.

Annyxh commented 2 years ago

Thanks & that's a good example

rob3000 commented 2 years ago

No problems @Annyxh. Are you happy if i close this issue?