rob729 / Quiet_Hours

No more trouble to make silent mode ON/OFF manually every time.
3 stars 9 forks source link

Fixed Landscape UI #27

Closed coder2699 closed 4 years ago

coder2699 commented 4 years ago

Fixes #26

Screenshots for the change:

rob729 commented 4 years ago

@coder2699 Have a look at the settings fragment in landscape mode. The action bar title is not in the expected position. I would suggest shifting the title to the left side of the action bar instead of the center.

rob729 commented 4 years ago

@coder2699 The NewProfileFragment layout not designed properly. Make it scrollable to avoid such overlaps.

coder2699 commented 4 years ago

@coder2699 The NewProfileFragment layout not designed properly. Make it scrollable to avoid such overlaps.

@rob729 does it differes from device to device? because in my emulator i m getting newProfileFragment as

coder2699 commented 4 years ago

@coder2699 Have a look at the settings fragment in landscape mode. The action bar title is not in the expected position. I would suggest shifting the title to the left side of the action bar instead of the center.

Even in the Portrait mode it should be at the left, instead of center?

rob729 commented 4 years ago

@coder2699 Have a look at the settings fragment in landscape mode. The action bar title is not in the expected position. I would suggest shifting the title to the left side of the action bar instead of the center.

Even in the Portrait mode it should be at the left, instead of center?

Yes

rob729 commented 4 years ago

@coder2699 The NewProfileFragment layout not designed properly. Make it scrollable to avoid such overlaps.

@rob729 does it differes from device to device? because in my emulator i m getting newProfileFragment as

It depends on how you design the UI.

coder2699 commented 4 years ago

@rob729 Fixed Settings->Action bar and made NewProfileFragment Scrollable

rob729 commented 4 years ago

Seems to be fine. Push the changes so that I can test it on my device.

coder2699 commented 4 years ago

@rob729 Please check this.

coder2699 commented 4 years ago

@rob Please check now.

rob729 commented 4 years ago

@coder2699 Share the screenshot of NewProfileFragment.

coder2699 commented 4 years ago

@rob what shall I do?

coder2699 commented 4 years ago

Capture

coder2699 commented 4 years ago

@rob have a look. the linear layout inside scroll view is not stretching till full screen length even though its height is match parent. And same happens on using relative layout. I think this is just complicating a simple issue.

rob729 commented 4 years ago

I guess you need to first stop tagging random people and asking them what should be done. Regarding the problem, as I mentioned earlier the problem is arising because of scrollview. You need to search online on how to make the scrollview cover the whole screen. I don't think I am complicating the issue by asking you to make a single layout file instead of two and I hope after seeing the end resultant code you will be able to realize that.

coder2699 commented 4 years ago
rob729 commented 4 years ago

give @coder2699 5 points