search

rob729 / Quiet_Hours

No more trouble to make silent mode ON/OFF manually every time.
3 stars 9 forks source link

Delete Currently active profile #44

Closed coder2699 closed 4 years ago

coder2699 commented 4 years ago

Fixes #43

coder2699 commented 4 years ago

Briefly tell why have you used "ActiveProfileId" in shared preference

When user deletes by swiping a profile, we must check that is it active or not. We could have used ActiveProfileName also to compare that. But considering that there's no restrictions on creating multiple profiles with same name I used ActiveProfileId

coder2699 commented 4 years ago

App not working as expected in case of delete all profiles. You should thoroughly test the app before raising the PR. It wastes a lot of time while reviewing the code and introduces bugs in some cases when an issue in a PR goes unnoticed and it gets merged The above is a generalized comment based on your previous and current PR.

@rob729 I will check once more, regarding delete all profiles and try to improve in future.

coder2699 commented 4 years ago

@rob729 Whenever you are free, please let me know if still there is some problem.

rob729 commented 4 years ago

give @coder2699 5 points