search

rob729 / Quiet_Hours

No more trouble to make silent mode ON/OFF manually every time.
3 stars 9 forks source link

Added Repeat Weekly Feature #48

Closed coder2699 closed 4 years ago

coder2699 commented 4 years ago

Fixes #20

Changes: Added repeat weekly feature

coder2699 commented 4 years ago

@rob729 Please have a look at this PR. One more thing, since PeriodicTimeWorkRequest is calculating 7*24hours, so it was not practically possible to check it.

So what I did was, in order to check the working, I changed the PeriodicTimeWorkRequest to 16 minutes (as it should be atleast 15mins), and it was working fine. So if you want to check the app functioning it can be done this way.

coder2699 commented 4 years ago

@rob729 Please have a look

rob729 commented 4 years ago

@coder2699 Looks better. Go ahead with this change.

coder2699 commented 4 years ago

@coder2699 Looks better. Go ahead with this change.

@rob729 I have pushed the code with the asked changes.

rob729 commented 4 years ago

@coder2699 Can you share an APK in which the PeriodicTimeWorkRequest interval is 16 minutes for testing purpose?

coder2699 commented 4 years ago

@coder2699 Can you share an APK in which the PeriodicTimeWorkRequest interval is 16 minutes for testing purpose?

@rob729 Yes, you can use the link below to get app apk for testing purpose. https://drive.google.com/file/d/13axyQkGjpR16MmtusjvEef67LNCWH2Gz/view?usp=sharing

coder2699 commented 4 years ago

@rob729 Please check

rob729 commented 4 years ago

@coder2699 Share a screenshot in case of a non-repeating profile also.

coder2699 commented 4 years ago

@coder2699 Share a screenshot in case of a non-repeating profile also.

@rob729 This is SS for non repeating.

rob729 commented 4 years ago

give @coder2699 150 points