search

rob729 / Quiet_Hours

No more trouble to make silent mode ON/OFF manually every time.
3 stars 9 forks source link

Implemented App Intro #60

Closed Haid-Faiz closed 3 years ago

Haid-Faiz commented 3 years ago

Fixes #46

Changes: Implemented App intro using App intro library... and old material intro features are now showing in app intro.

Screenshots for the change:

Haid-Faiz commented 3 years ago

@rob729 have a look... ktlint check fixed

rob729 commented 3 years ago

@Haid-Faiz UI added is not optimized for dark mode as the text is not visible in dark mode.

Haid-Faiz commented 3 years ago

@rob729 ok i'll fix it...

Haid-Faiz commented 3 years ago

@rob729 Should i show status bar in app intro...?

rob729 commented 3 years ago

@rob729 Should i show status bar in app intro...?

No

rob729 commented 3 years ago

@Haid-Faiz Also I didn't ask you to add a screenshot of the previous app intro in this one. You had to add the info about the earlier highlighted features. The current images are not looking good. Maybe you can look into the apps which have implemented the same library to get a better idea. The list of apps using the same library is mentioned in the readme of the library. Keep in mind to highlight the features which are offered in the current version like swipe to delete, click on the profile to get more details, pause/resume profile. Remove the add profile page, it seems to be too basic to show in app intro.

Just to give a little better idea, in case of the "click on the profile to get more details" feature you can add the screenshot of the details fragment bottom sheet. For the "swipe to delete" feature you can show a sample profile which is swiped towards the right little bit showing the delete icon with the red background.

rob729 commented 3 years ago

@Haid-Faiz In the second intro screen, crop out the app bar from screenshot

Haid-Faiz commented 3 years ago

@rob729 ok

rob729 commented 3 years ago

@Haid-Faiz In the second app intro screen, it should be "Swipe left" instead of slide. Use the screenshot from the latest version of the app as in the second screenshot the pause/resume toggle is missing. Also, add the pause/resume profile feature in app intro. Use roboto_slab font in the app intro.

Haid-Faiz commented 3 years ago

@rob729 ok

rob729 commented 3 years ago

@Haid-Faiz The checks are failing. Fix them.

Haid-Faiz commented 3 years ago

@rob729 Ya.... i will fix.. i'll msg you when everything will completed

Haid-Faiz commented 3 years ago

@rob729 have a look now... & what is this codeClimate check....?? it is showing some similar code warning... How to pass this check ?

rob729 commented 3 years ago

Click on the details present on the codeclimate check and it will show what are the problems present in the PR.

Haid-Faiz commented 3 years ago

@rob729 i have fixed 2 issues out of 4 of codeclimate but remaining 2 issues are not issues i think... because it is showing 2 similar block of code have found but actually one block is overridden method onSkipPressed() & second block is onDonePressed() present in IntroScreen Activity. So, now what should i do to fix this

rob729 commented 3 years ago

@rob729 i have fixed 2 issues out of 4 of codeclimate but remaining 2 issues are not issues i think... because it is showing 2 similar block of code have found but actually one block is overridden method onSkipPressed() & second block is onDonePressed() present in IntroScreen Activity. So, now what should i do to fix this

Since there is same code in both functions, move that block of code into a function. You can name the function to be navigateToMainFragment().

rob729 commented 3 years ago

@Haid-Faiz One more thing, in the second app intro screen make it "swipe left a profile to delete it". Also, make 'Y' capital of you.

Haid-Faiz commented 3 years ago

@rob729 i have fixed 2 issues out of 4 of codeclimate but remaining 2 issues are not issues i think... because it is showing 2 similar block of code have found but actually one block is overridden method onSkipPressed() & second block is onDonePressed() present in IntroScreen Activity. So, now what should i do to fix this

Since there is same code in both functions, move that block of code into a function. You can name the function to be navigateToMainFragment().

@rob729 Ya, fixed this but read your msg after fixing it.. i mean i named it appIntroClickListeners()

Haid-Faiz commented 3 years ago

@Haid-Faiz One more thing, in the second app intro screen make it "swipe left a profile to delete it". Also, make 'Y' capital of you.

ok

Haid-Faiz commented 3 years ago

@rob729 navigateToMainFragment() OR navigateToMainActivity()

Haid-Faiz commented 3 years ago

@rob729 Now, have a look

rob729 commented 3 years ago

give @Haid-Faiz 75 points