search

robaho / httpserver

a lightweight zero dependency JDK http server implementation designed for embedding and optimized for virtual threads
Other
16 stars 3 forks source link

Fix #2 NPE when used with Log4J2-JPL #3

Closed taranion closed 3 months ago

taranion commented 3 months ago

This little patch solved the Log4J bridge problem for me. LogManager.getLogger(name) returns NULL, if the logger did not exist before - Logger.getLogger(name) does create an eventually not yet existing logger or returns the existing one.

Thank you for creating this project - it helps me preventing the bloat from full blown webserver frameworks.

robaho commented 3 months ago

Thanks for the patch - I am glad the project is helping you.

I am not sure this change is correct though. I had added the utilities Logger for per instance logging, when the original code only used the System logger facilities - in order to change the filtering.

I am going to need to review the best way to fix this - I probably did something wrong. I normally only use the utility loggers, but I was trying to stay as close as possible to the original JDK httpserver code.

Are you certain your log4j is setup properly, and the System loggers are being redirected there?

robaho commented 3 months ago

Thank you for the PR. After reviewing the apis your code change was correct, but I modified the PR slightly to remove the unused imports, and avoid white space changes.