search

robaho / httpserver

a lightweight zero dependency JDK http server implementation designed for embedding and optimized for virtual threads
Other
16 stars 3 forks source link

Would you like "Style" PRs that make some classes final? #6

Open rbygrave opened 21 hours ago

rbygrave commented 21 hours ago

Hi, there are some classes that look to me like they could be final. Are you interested in getting PR's for adding the final modifier to some of these classes?

As another style note, I see some methods that implement an interface method are not annotated with @Override. Are you interested in PR's that would add @Override to these methods [conceptually this improves support for refactoring such as removing methods from interfaces].

Are either of these something you'd like to get PR's for?

Cheers, Rob.

robaho commented 20 hours ago

Honestly, it depends… a lot of the structure, classnames, etc are taken directly from the JDK code. I only deviated when it was absolutely necessary in order to limit the scope of changes the JDK team would need to review if they wanted incorporate.

You are more than welcome to do a preview PR so I can review more specifics of where/what you want to fix.

rbygrave commented 20 hours ago

Here is a preview PR / example - https://github.com/robaho/httpserver/pull/7