robaho / seashore

easy to use mac osx image editing application for the rest of us
GNU General Public License v2.0
439 stars 19 forks source link

Universal Binary for Apple Silicon #139

Closed thebitstick closed 2 years ago

thebitstick commented 3 years ago

Seashore works great through Rosetta, but a native binary would be nice!

robaho commented 3 years ago

Thank you for the input. It is actually a bit of work to port, and given that I don't have hardware to test on, and any donations haven't come close to even a down payment, it is doubtful.

If I am going to make an effort in this area, I will probably do a complete rewrite in a new commercial app.

ThatGuySam commented 3 years ago

@robaho Is this closed because you don't have a method to test it?

robaho commented 3 years ago

Pretty much. It’s hard to accept a PR that I have no way of testing.

ThatGuySam commented 3 years ago

If you can provide a list of specific features to test along with some sample files, I can create a callout for testers to create a screen recorded review of the Universal Binary.

thebitstick commented 3 years ago

I volunteer to test on my Mac mini M1.

ThatGuySam commented 3 years ago

@thebitstick That's awesome!!

ThatGuySam commented 3 years ago

I'm sure @robaho will have more specific things to try, but if you could post a screen recording of the following that would be a good start:

If you need a screen recording app you can simply have Quicktime record the screen by pressing: Command + Shift + 5

robaho commented 3 years ago

There is no PR to support Apple silicon. I don't have the time to create and test one. It is more than just setting some complier flags - there is some C code and other memory manipulation operations that I assume need to be changed for direct compilation.

Since Seashore is released on the App Store, I cannot submit a partially working, or partially tested App. So there would need to be a full PR with complete testing and test reports of all operations. It is a lot of work IMO.

robaho commented 3 years ago

As I mentioned, if I invest the time to support Apple silicon it will probably be on a completely new version written from the ground up in Swift. That being said, I will accept a PR to support Apple silicon, but the bar is very high for what needs to be included - since I can't break the App Store version.

robaho commented 3 years ago

I am re-opening the issue so a PR can be created against it.

ThatGuySam commented 3 years ago

Fair enough!

mugsuk commented 2 years ago

@robaho, I couldn't find a way to contact you other than through issues, to thank you so much for what you have done for Seashore. I have been using it since it was first released, then resorted to Gimp when seashore died; I have not had to open Gimp again since you resurrected this, and I use it daily. This level of quality for open source software on the Mac is phenomenal. Thanks again

robaho commented 2 years ago

Thanks for the kind words @mugsuk

robaho commented 2 years ago

fixed in 3.01