search

robaho / seashore

easy to use mac osx image editing application for the rest of us
GNU General Public License v2.0
452 stars 20 forks source link

Font handling is broken #14

Closed tnakagome closed 5 years ago

tnakagome commented 5 years ago

When I try to insert a text, it is shown like black and white stripes. This occurs on both the latest MacOS 10.14 (just upgarded) and 10.13.6.

2018-12-25 9 18 19

Thanks.

robaho commented 5 years ago

@tnakagome can you reproduce this with version 1.0.0 ? I need exact steps to reproduce, because it works for me.

robaho commented 5 years ago

Also, I only have 10.13.6, and version 1.1.2 is working for me.

tnakagome commented 5 years ago

It's as simple as creating a new image and insert a text. I was using 0.6.6 when I reported, but it still happens on 1.1.3 with 10.14. My OS language is Japanese, if that matters.

robaho commented 5 years ago

I will try reviewing the relevant code again, but it is very hard to fix if I can’t make it happen. Also I can’t run 10.14 only 10.13 so I’m stuck a bit.

On Dec 31, 2018, at 4:30 AM, Nakagome Tomoyuki notifications@github.com wrote:

It's as simple as creating a new image and insert a text. I was using 0.6.6 when I reported, but it still happens on 1.1.3 with 10.14. My OS language is Japanese, if that matters.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub, or mute the thread.

robaho commented 5 years ago

@tnakagome did you try with the 'high quality fringe' disabled ? Also, are you sure you don't have a 'texture' selected, maybe from a saved setting ?

Your screen capture is too small for me to see the foreground and background colors. Please expand and re-attach the capture.

robaho commented 5 years ago

@tnakagome also, can you please try with a standard font, like Lucidia, and ascii characters and report if it works. Thanks.

tnakagome commented 5 years ago

I have set the OS primary language to English and recorded a video, with "high quality fringe" turned off.

This is on Macbook Pro (13-inch 2016 model)

Interestingly, this did not happen a year ago on the same machine running 10.13. Maybe a few OS patches got applied since then. Not sure what else have changed.

Screen Recording 2019-01-01 at 10.58.19.mov.zip

robaho commented 5 years ago

@tnakagome thanks for the video, but it is not "wide enough" for me to see the color settings in the upper right corner. a screen capture of those would be fine.

A shout out to anyone running this on 10.14... Is it working for anyone ?

robaho commented 5 years ago

should be fixed in 2.0, I believe it is caused by graphics setups that use planar data, or possibly retina displays - either which I can't test, but it seems the text code was using a similar pattern as other code that was broken in this regard.

one thing to note, sub-pixel antialiasing is disabled, since it is really only useful when displaying on a monitor, and should not be in the pixel/image data itself. This should allow for more consistent font rendering.

also, the 'fringe' works, so you can pick up the underlying color information, but it is debatable if this should be used - since the text uses alpha pixels anyway - it will like any other when the layer is composited.

tnakagome commented 5 years ago

Working fine now. Thanks!