search

robaho / seashore

easy to use mac osx image editing application for the rest of us
GNU General Public License v2.0
439 stars 19 forks source link

"pinch" performs a zoom-in, not a pinch #172

Closed bosborne closed 1 year ago

bosborne commented 1 year ago

Might be that this is just my ignorance, but I expected "pinch" to be the opposite of "bump", i.e. distorts a sub-region of the image. Instead it changes the entire image by performing a zoom-in, actually removing pixels rather than distorting.

robaho commented 1 year ago

I believe this is working at expected. See https://cifilter.io/CIPinchDistortion/ for a discussion of how it works. The only issue I see is that the scale should be 0-1, and I am allowing larger values. I have fixed this in 3.11 (which is why it shows 0-100% in the video)

See this video of the pinch distortion in Seashore. At larger scales you can see the image clearly being pinched in to the area.

But, you did uncover an issue. The "bump" distortion should allow negative scales - which I believe the effect you are looking for. I fixed this in issue #173 in 3.11 as well.