robaho / seashore

easy to use mac osx image editing application for the rest of us
GNU General Public License v2.0
458 stars 20 forks source link

"Effects" displays empty list and breaks the toolbar #29

Closed 0xfadeef closed 5 years ago

0xfadeef commented 5 years ago

Press "Effect Tools" > "Effect" in the toolbar, then press "Choose Effect" button. Effects list is empty and after that it's not possible to pick any other tool or use window buttons (to close the window, for instance).

OS X 10.9.5, app version: 2.1.8

robaho commented 5 years ago

@0xfadeef I cannot reproduce this. Based on this and an earlier issue you reported, I would delete all copies of seashore and re-install. I would check the "console" for reported errors and attach them here - I have added logging during the effects loading to better diagnose problems.

0xfadeef commented 5 years ago

@robaho Not only I deleted previous version of Seashore, I rm-ed everything found with sudo find / -iname *seashore*. Issue remains. But, by your advice, I checked Console and there is bunch of error messages of the same form for each plugin installed.

12/1/19 19:51:40,646    Seashore[30377] Error loading /Users/sergeyfadeev/Applications/Seashore/Seashore.app/Contents/PlugIns/Brightness+.bundle/Contents/MacOS/Brightness+:  dlopen(/Users/sergeyfadeev/Applications/Seashore/Seashore.app/Contents/PlugIns/Brightness+.bundle/Contents/MacOS/Brightness+, 265): Library not loaded: /System/Library/Frameworks/CoreImage.framework/Versions/A/CoreImage
  Referenced from: /Users/sergeyfadeev/Applications/Seashore/Seashore.app/Contents/PlugIns/Brightness+.bundle/Contents/MacOS/Brightness+
  Reason: image not found
12/1/19 19:51:40,647    Seashore[30377] unable to open bundle NSBundle </Users/sergeyfadeev/Applications/Seashore/Seashore.app/Contents/PlugIns/Brightness+.bundle> (not yet loaded)
robaho commented 5 years ago

It looks like you are missing CoreImage - so it cant load the plugins. Your OS install looks broken... It should be in /System/Library/Frameworks/CoreImage.Framework.

Maybe search on your system to find that, and report back where it is located?

There’s a chance you can install it elsewhere I guess - but I thought it was part of the OS.

On Jan 12, 2019, at 11:05 AM, 0xfadeef notifications@github.com wrote:

@robaho https://github.com/robaho Not only I deleted previous version of Seashore, I rm-ed everything found with sudo find / -iname seashore. Issue remains. But, by your advice, I checked Console and there is bunch of error messages of the same form for each plugin installed.

12/1/19 19:51:40,646 Seashore[30377] Error loading /Users/sergeyfadeev/Applications/Seashore/Seashore.app/Contents/PlugIns/Brightness+.bundle/Contents/MacOS/Brightness+: dlopen(/Users/sergeyfadeev/Applications/Seashore/Seashore.app/Contents/PlugIns/Brightness+.bundle/Contents/MacOS/Brightness+, 265): Library not loaded: /System/Library/Frameworks/CoreImage.framework/Versions/A/CoreImage Referenced from: /Users/sergeyfadeev/Applications/Seashore/Seashore.app/Contents/PlugIns/Brightness+.bundle/Contents/MacOS/Brightness+ Reason: image not found 12/1/19 19:51:40,647 Seashore[30377] unable to open bundle NSBundle </Users/sergeyfadeev/Applications/Seashore/Seashore.app/Contents/PlugIns/Brightness+.bundle> (not yet loaded) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/robaho/seashore/issues/29#issuecomment-453763658, or mute the thread https://github.com/notifications/unsubscribe-auth/AEuqcaFIkxcQyuSYAZ-sFGjr3e_Kc8vxks5vChXxgaJpZM4Z8qp8.

robaho commented 5 years ago

@0xfadeef see this http://flummox-engineering.blogspot.com/2018/08/missing-coreimage-framework-in-macos-yosemite-10-10-5-quartz-framework.html

Not sure why it is being built that way, since I have compatibility set to 10.7 but I will investigate. Hopefully I can fix it for the next build.

0xfadeef commented 5 years ago

@robaho I symlinked CoreImage.framework as it was suggested and looks like it resolves the problem, the app is working fine right now. Thank you for help.

robaho commented 5 years ago

@0xfadeef I'll probably ask you to remove the symlink and test with the next version - obviously doing the symlink is not ideal.

robaho commented 5 years ago

I removed any direct references to CoreImage in the projects in 2.1.9 - the built plugin bundles still seem to reference the direct path, but hopefully it works in the wild.

0xfadeef commented 5 years ago

@robaho I unlinked CoreImage.framework and checked with version 2.1.9. Unfortunately, the issue still present. Please check the screenshot.

Console log reports exactly the same error.

robaho commented 5 years ago

I am re-opening. I figured out the issue. The plugins were being required to compile for 10.14+, so when linking it assumed that is where the CoreImage framework was. After I switched to 10.7, they have different linkage instructions.

I am in the process of making a new build.

robaho commented 5 years ago

This should be fixed in version 2.2.0

0xfadeef commented 5 years ago

@robaho So far not reproducible on 2.2.0. Thank you!