search

robaho / seashore

easy to use mac osx image editing application for the rest of us
GNU General Public License v2.0
458 stars 20 forks source link

App crashes when trying to close the window #30

Closed 0xfadeef closed 5 years ago

0xfadeef commented 5 years ago

Trying to close the app window with a window button or pressing Cmd+W results in "Seashore quit unexpectedly." dialog.

OS X 10.9.5, app version: 2.1.8

robaho commented 5 years ago

@0xfadeef I cannot reproduce this. Can you post the "details" from the crash please - they should be available in the crash dialog. Maybe some additional steps to reproduce. It is working fine for me.

0xfadeef commented 5 years ago

@robaho There are no additional steps. You just start the app, open new file or some existing file, then try to close a window. That's it. Please check an excerpt from system.log:

Jan 12 20:07:02 AIR.local Seashore[30486]: find_shared_window: WID 12146
Jan 12 20:07:02 AIR.local Seashore[30486]: CGSOrderWindowListWithGroups: invalid window ID (12146)
Jan 12 20:07:02 AIR.local Seashore[30486]: CGSOrderWindowList: NULL list pointer or empty list
Jan 12 20:07:05 AIR com.apple.launchd.peruser.501[288] (app.seashore.56528[30486]): Job appears to have crashed: Segmentation fault: 11
Jan 12 20:07:05 AIR.local ReportCrash[30491]: Saved crash report for Seashore[30486] version 2.1.8 (201901092) to /Users/sergeyfadeev/Library/Logs/DiagnosticReports/Seashore_2019-01-12-200705_AIR.crash
robaho commented 5 years ago

@0xfadeef is this working now that the effects are working ? I am thinking they may be related.

robaho commented 5 years ago

@0xfadeef also, there should be a crash report in /Users/sergeyfadeev/Library/Logs/DiagnosticReports/ if you could attach that here if not resolved, I would appreciate it.

robaho commented 5 years ago

Going to close this since I think it was related to the startup issues not being able to find core image.

0xfadeef commented 5 years ago

@robaho These issues are not related. Whether effects are working or not, the app still crashes on win close. Please see crash report (for version 2.1.9): Seashore_2019-01-15-223654_AIR.log

robaho commented 5 years ago

@0xfadeef I still can't reproduce. I need more details. If you open the application fresh, create a blank document, then use cmd-W does it crash? If you make some changes then use cmd-W do you get the prompt to save, and then does it crash?

The crash log shows it dying in OSX internals, and I can't reproduce, so it does possible point to a bug in Mavericks that Seashore is exposing.

Maybe if you take a video of exactly what you are doing and post it will be easier? I also need to now all of the "view" settings from that menu.

robaho commented 5 years ago

@0xfadeef it may of been caused by the incorrect version compiling - the 2.2.0 release may fix the issue

robaho commented 5 years ago

@0xfadeef did the 2.2 release resolve this for you?

0xfadeef commented 5 years ago

@robaho

did the 2.2 release resolve this for you?

Unfortunately, no. Still crashes.

If you open the application fresh, create a blank document, then use cmd-W does it crash?

Yes. Same if you open some existing image after the app starts.

If you make some changes then use cmd-W do you get the prompt to save, and then does it crash?

Depends. If you press "Don's save", then it crashes. If you choose to save the image, then no, it doesn't crash. Weird thing is, however, after you save the image, the app doesn't close the window. If you try to close again, no crash, all good.

I also need to now all of the "view" settings from that menu.

I'm afraid I don't understand what "menu" are you referring to?

0xfadeef commented 5 years ago

Also, I'd like to mention that afair previous version of Seashore I had installed (don't remember version name) didn't have this bug on this OS.

robaho commented 5 years ago

@0xfadeef are you using the version from the App Store? If so, you can use the "report to Apple" and I'll get a detailed report of the problem which might hopefully allow me to fix. Still can't reproduce in any way.

robaho commented 5 years ago

@0xfadeef it appears it is a bug in the version of the OS you are running. There are similar reports to yours all over the web regarding the NSRulerView and this crash. That being said, there is a work-around I am going to try.

robaho commented 5 years ago

Hopefully it is now fixed in 2.2.1 - not sure when that will get posted to the app store.

0xfadeef commented 5 years ago

@robaho Maybe you can provide dmg image for 2.2.1 so I can check whether the issue is actually resolved?

robaho commented 5 years ago

@0xfadeef here, I am attaching a dmg - it is only for testing whether the close works - it may have other issues since it hasn't been fully tested, and it won't be updatable. please test as soon as you can. thanks. I needed to zip the dmg in order to attach here.

seashore-bin-debug.dmg.zip

0xfadeef commented 5 years ago

2019-01-17_22-32-35 17/1/19 22:34:59,586 CoreServicesUIAgent[45441] Error SecAssessmentCreate: The operation couldn’t be completed. (OSStatus error -67055.) 17/1/19 22:35:05,872 com.apple.launchd.peruser.501[288] ([0x0-0x4d54d5].app.seashore[45439]) Exited: Killed: 9

robaho commented 5 years ago

@0xfadeef I just downloaded the posted file and it opens fine for me - I think you need to use "save as", then use the finder to unzip it, then mount the dmg. It is probably a chrome thing auto-opening the zip.

robaho commented 5 years ago

@0xfadeef I just downloaded with Safari - you might want to try that.

0xfadeef commented 5 years ago

@robaho Just repeated entire process several times downloading with Safari and I always unzip manually. Same result: "Seashore.app" is damaged and can't be opened.

robaho commented 5 years ago

@0xfadeef this may help https://secure.clcbio.com/helpspot/index.php?pg=kb.page&id=323 it is something with your system I think. I downloaded again and it opens fine.

robaho commented 5 years ago

@0xfadeef this may be easier to follow https://www.iotgadgets.com/2018/09/how-to-fix-application-is-damaged-and-cant-be-opened-error-in-macos-mojave-and-high-sierra/

robaho commented 5 years ago

@0xfadeef you may also just be able to right-click and open to get additional security prompts

robaho commented 5 years ago

@0xfadeef I would really like to resolve this for you in the next release. To do that, I could use a little more prompt feedback, otherwise I am going to have to put it on the back-burner.

Please advise if you were able to open and run the DMG I attached here previously. Thanks.

0xfadeef commented 5 years ago

@robaho Sorry for delayed response. As suggested, I switched "Allow apps from..." option under OS security settings to "Anywhere" (I had no idea such option even exists). Now "app is damaged" dialog is not showing up, but the issue is still present. Please check this screen recording: https://youtu.be/Kb-Ov00Iauc

0xfadeef commented 5 years ago

Still reproducible in 2.3.3 (see crash report below). But it looks like this time the issue only appears before the app is being used for a while. Could not reproduce on a fresh install.

Seashore_2019-01-30-002835_AIR.log

robaho commented 5 years ago

I am going to attempt one last fix to this in the next release. I honestly believe it is a bug in your installed OS version, because it is not being reported anywhere else - but I'll give it a try.

0xfadeef commented 5 years ago

@robaho I doubt it's OS-side issue since all the other apps I have installed seem to handle main window closing just fine.

robaho commented 5 years ago

@0xfadeef Can you find another app that uses rulers? Possibly Pages with rulers turned on, and see if it fails when trying to close the window ? And it's definitely an OS issue, or it would crash for me (and all the others) when they performed the same operation.

robaho commented 5 years ago

@0xfadeef Hi. I posted a 2.3.4.beta.dmg in the 2.3.3 releases. Can you please pull it down and see if it fixes this issue? Thanks for your help.

0xfadeef commented 5 years ago

@robaho I need some time to check if it's fixed, as I wrote the issue is not reproducible on a fresh install. I'll try to report asap.

0xfadeef commented 5 years ago

@robaho Not reproducible on version 2.3.4.

robaho commented 5 years ago

Great. Thanks for helping.