robaho / seashore

easy to use mac osx image editing application for the rest of us
GNU General Public License v2.0
458 stars 20 forks source link

Main window is not created on new/open #40

Closed 0xfadeef closed 5 years ago

0xfadeef commented 5 years ago

After the app starts it's not possible neither create a new image nor open an existing one since main window doesn't not show up. See error log below.

OS X 10.9.5, app version: 2.3.0; 2.3.1

28/1/19 00:15:39,249 Seashore[75884]: -[NSTextField setAllowsDefaultTighteningForTruncation:]: unrecognized selector sent to instance 0x7fe1e26ea700
28/1/19 00:15:39,340 Seashore[75884]: (
    0   CoreFoundation                      0x00007fff9521d25c __exceptionPreprocess + 172
    1   libobjc.A.dylib                     0x00007fff8c155e75 objc_exception_throw + 43
    2   CoreFoundation                      0x00007fff9522012d -[NSObject(NSObject) doesNotRecognizeSelector:] + 205
    3   CoreFoundation                      0x00007fff9517b272 ___forwarding___ + 1010
    4   CoreFoundation                      0x00007fff9517adf8 _CF_forwarding_prep_0 + 120
    5   Seashore                            0x0000000100a485de -[StatusBarView awakeFromNib] + 46
    6   CoreFoundation                      0x00007fff9513d309 -[NSSet makeObjectsPerformSelector:] + 201
    7   AppKit                              0x00007fff8d1a9afd -[NSIBObjectData nibInstantiateWithOwner:topLevelObjects:] + 1157
    8   AppKit                              0x00007fff8d19e5ce loadNib + 327
    9   AppKit                              0x00007fff8d19db6c +[NSBundle(NSNibLoading) _loadNibFile:nameTable:withZone:ownerBundle:] + 288
    10  AppKit                              0x00007fff8d4324d2 +[NSBundle(NSNibLoading) loadNibFile:externalNameTable:withZone:] + 140
    11  AppKit                              0x00007fff8d4322ca -[NSWindowController loadWindow] + 196
    12  AppKit                              0x00007fff8d436f88 -[NSWindowController window] + 80
    13  AppKit                              0x00007fff8d4380f0 -[NSWindowController showWindow:] + 36
    14  AppKit                              0x00007fff8d5045f5 -[NSDocument showWindows] + 100
    15  AppKit                              0x00007fff8d503168 -[NSDocumentController openUntitledDocumentAndDisplay:error:] + 458
    16  AppKit                              0x00007fff8d502f5f -[NSDocumentController newDocument:] + 36
    17  Seashore                            0x0000000100a4d1f3 -[SeaDocumentController createDocument:] + 339
    18  AppKit                              0x00007fff8d3d9260 -[NSApplication sendAction:to:from:] + 327
    19  AppKit                              0x00007fff8d3d90de -[NSControl sendAction:to:] + 86
    20  AppKit                              0x00007fff8d425c4d -[NSCell _sendActionFrom:] + 128
    21  AppKit                              0x00007fff8d43f655 -[NSCell trackMouse:inRect:ofView:untilMouseUp:] + 2316
    22  AppKit                              0x00007fff8d43ea27 -[NSButtonCell trackMouse:inRect:ofView:untilMouseUp:] + 487
    23  AppKit                              0x00007fff8d43e13d -[NSControl mouseDown:] + 706
    24  AppKit                              0x00007fff8d3bfa58 -[NSWindow sendEvent:] + 11296
    25  AppKit                              0x00007fff8d35e5d4 -[NSApplication sendEvent:] + 2021
    26  AppKit                              0x00007fff8d1ae9f9 -[NSApplication run] + 646
    27  AppKit                              0x00007fff8d199783 NSApplicationMain + 940
    28  Seashore                            0x00000001009c1484 start + 52
    29  ???                                 0x0000000000000002 0x0 + 2
)
28/1/19 00:15:39,380 Seashore[75884]: *** WARNING: -[NSImage compositeToPoint:operation:] is deprecated in MacOSX 10.8 and later. Please use -[NSImage drawAtPoint:fromRect:operation:fraction:] instead.
28/1/19 00:15:39,381 Seashore[75884]: *** WARNING: -[NSImage compositeToPoint:fromRect:operation:] is deprecated in MacOSX 10.8 and later. Please use -[NSImage drawAtPoint:fromRect:operation:fraction:] instead.
robaho commented 5 years ago

fixed in 2.3.2, it is a feature that is only in 10.11+

0xfadeef commented 5 years ago

@robaho Not fixed in 2.3.2! (I don't understand why close the issue before you make sure that bug is fixed?)

robaho commented 5 years ago

It’s a housekeeping thing. I don’t have an old OS X to test on. But just saying it doesn’t work and not posting the log does not help.

robaho commented 5 years ago

Please post the log or I cannot fix.

robaho commented 5 years ago

@0xfadeef can you please post an updated crash log. I removed the offending code, it must be something else. Thank you.

0xfadeef commented 5 years ago

@robaho Afar the log for 2.3.2 is exactly the same as it's posted in top comment for 2.3.1 version. I don't have an access to my notebook right now, I can verify this in a couple of hours.

robaho commented 5 years ago

@0xfadeef than you - I appreciate it - did you get the build from github ? If so, maybe I didn't post the correct version, because I removed the code - can't see how it would fail exactly the same way.

robaho commented 5 years ago

@0xfadeef I posted a rebuilt 2.3.2 dmg in the releases. Please test with that, and then report back with any crash log - I'll get it working - probably trivial, but I have no way to make it fail.

0xfadeef commented 5 years ago

@robaho Not fixed in 2.3.2.updated. Please check Console logs below for both versions. Honestly, I can't see any differences from 2.3.1 log.

Seashore-2.3.2-create_image.log Seashore-2.3.2-open_image.log Seashore-2.3.2.updated-create_image.log Seashore-2.3.2.updated-open_image.log

robaho commented 5 years ago

It was actually a different API, but in the same place. It should be working in 2.3.3 which I am posting to releases now. Please verify, and report back. I will leave this open until you do.

robaho commented 5 years ago

@0xfadeef 2.3.3 is available, please let me know as soon as possible so I can update the App Store. thanks.

0xfadeef commented 5 years ago

@robaho Not reproducible in version 2.3.3.

robaho commented 5 years ago

@0xfadeef thanks.